Skip to content

feat(cli.rs): add context to errors - #1674

Merged
lucasfernog merged 1 commit into
devfrom
feat/cli.rs-context
May 2, 2021
Merged

feat(cli.rs): add context to errors#1674
lucasfernog merged 1 commit into
devfrom
feat/cli.rs-context

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Currently it's super hard to track CLI errors (specially IO errors, since it only outputs No such file or directory). This PR uses anyhow::Context to improve the error message.

@lucasfernog
lucasfernog requested a review from a team as a code owner May 1, 2021 15:08
@lucasfernog
lucasfernog requested a review from a team May 1, 2021 15:08
@lucasfernog
lucasfernog merged commit 5cc4b11 into dev May 2, 2021
@lucasfernog
lucasfernog deleted the feat/cli.rs-context branch May 2, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant