Skip to content

fix(core): notification permission check when !allowlisted, closes #1666#1677

Merged
lucasfernog merged 2 commits intodevfrom
fix/notification-permission-check
May 2, 2021
Merged

fix(core): notification permission check when !allowlisted, closes #1666#1677
lucasfernog merged 2 commits intodevfrom
fix/notification-permission-check

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Fixes a console error message when the notification API isn't allowlisted.

@lucasfernog lucasfernog requested a review from a team as a code owner May 2, 2021 12:16
@lucasfernog lucasfernog requested a review from a team May 2, 2021 12:16
@lucasfernog lucasfernog merged commit 8941790 into dev May 2, 2021
@lucasfernog lucasfernog deleted the fix/notification-permission-check branch May 2, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant