Skip to content

refactor(core): add window getters, physical & logical sizes/positions#1723

Merged
lucasfernog merged 6 commits intodevfrom
feat/window-getters
May 5, 2021
Merged

refactor(core): add window getters, physical & logical sizes/positions#1723
lucasfernog merged 6 commits intodevfrom
feat/window-getters

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Window events will be added on the next PR.

@lucasfernog lucasfernog requested a review from a team as a code owner May 5, 2021 20:28
@lucasfernog lucasfernog requested review from a team May 5, 2021 20:28
@lucasfernog lucasfernog merged commit 6bfac86 into dev May 5, 2021
@lucasfernog lucasfernog deleted the feat/window-getters branch May 5, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant