feat(core): add default Args to all types exposing Params#1777
Merged
lucasfernog merged 3 commits intodevfrom May 11, 2021
Merged
feat(core): add default Args to all types exposing Params#1777lucasfernog merged 3 commits intodevfrom
lucasfernog merged 3 commits intodevfrom
Conversation
wusyong
approved these changes
May 11, 2021
lucasfernog
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
allows using no generic parameters when the user is using
Builder::default().e.g. from
to
Marked as draft because it's late and I haven't tested it in the slightest. The command system extensively uses type inference, so we want to make sure that this doesn't break anything. It's not a breaking change to add this PR, so we are free to do so at any time in the future. Removing it after adding it would be a breaking change, so I want to be sure that it doesn't affect command inference first.