fix: CTA cache and vite build - #1806
Merged
Merged
Conversation
this also makes it closer to the production version and less likely to accidentally introudce an issue
jbolda
force-pushed
the
fix/cta-cache-and-vite-build
branch
from
May 12, 2021 16:24
da121f3 to
ce2937f
Compare
jbolda
force-pushed
the
fix/cta-cache-and-vite-build
branch
from
May 12, 2021 16:34
ce2937f to
a7113cc
Compare
jbolda
force-pushed
the
fix/cta-cache-and-vite-build
branch
from
May 12, 2021 19:13
9412d40 to
57dc7a3
Compare
lucasfernog
approved these changes
May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
This addresses some issues around
npxbeing extra cache-y than in the past, and deals with bugs around npm and installing esbuild.Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: