Skip to content

refactor(macros): explicitly pass idents - #1812

Merged
lucasfernog merged 1 commit into
devfrom
refactor/command-macro-bindings
May 13, 2021
Merged

lucasfernog merged 1 commit into
devfrom
refactor/command-macro-bindings

Conversation

@chippers

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Cleans up the code a bit by removing all "expected to exist" items used inside command macro codegen to explicitly passed items. This should make it easier in the future to change the binding names if wanted, and to make related mistakes in new codegen code less likely.

@chippers
chippers requested a review from a team as a code owner May 12, 2021 22:41
@chippers
chippers requested a review from a team May 12, 2021 22:41
@lucasfernog
lucasfernog merged commit 39f8f26 into dev May 13, 2021
@lucasfernog
lucasfernog deleted the refactor/command-macro-bindings branch May 13, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants