Skip to content

added cargo features to tauri config#1824

Merged
lucasfernog merged 2 commits intotauri-apps:devfrom
crapStone:feature/cargo-features
May 13, 2021
Merged

added cargo features to tauri config#1824
lucasfernog merged 2 commits intotauri-apps:devfrom
crapStone:feature/cargo-features

Conversation

@crapStone
Copy link
Contributor

@crapStone crapStone commented May 13, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

Other information:

I wanted to hide some functionality behind features in my Cargo.toml but had to put the features i wanted into the default features. The dev command didn't work at all, because it deactivates the default features.

With this change you can put all your wanted features into the tauri.conf.json and it starts the dev and release with these.

@crapStone crapStone requested a review from a team May 13, 2021 16:57
@6543 6543 mentioned this pull request May 13, 2021
Merged
lucasfernog
lucasfernog approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@crapStone crapStone requested a review from a team as a code owner May 13, 2021 20:01
@lucasfernog lucasfernog merged commit 2b814e9 into tauri-apps:dev May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crapStone @lucasfernog