Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow wry to be an optional dep again (fix #1841) #1854

Merged
merged 2 commits into from
May 18, 2021

Conversation

chippers
Copy link
Member

@chippers chippers commented May 18, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

crate::manager::default_args! {
  /// A menu event that was triggered on a window.
  #[cfg(feature = "menu")]
  #[cfg_attr(doc_cfg, doc(cfg(feature = "menu")))]
  pub struct WindowMenuEvent<P: Params> {
    pub(crate) menu_item_id: P::MenuId,
    pub(crate) window: Window<P>,
  }
}

turns into

#[doc = " A menu event that was triggered on a window."]
#[cfg(feature = "menu")]
#[cfg_attr(doc_cfg, doc(cfg(feature = "menu")))]
#[cfg(feature = "wry")]
pub struct WindowMenuEvent<P: Params = crate::manager::DefaultArgs> {
    pub(crate) menu_item_id: P::MenuId,
    pub(crate) window: Window<P>,
}
#[doc = " A menu event that was triggered on a window."]
#[cfg(feature = "menu")]
#[cfg_attr(doc_cfg, doc(cfg(feature = "menu")))]
#[cfg(not(feature = "wry"))]
pub struct WindowMenuEvent<P: Params> {
    pub(crate) menu_item_id: P::MenuId,
    pub(crate) window: Window<P>,
}

@chippers chippers requested a review from a team as a code owner May 18, 2021 03:09
@chippers chippers requested a review from a team May 18, 2021 03:09
@lucasfernog lucasfernog merged commit 3d8dcbb into dev May 18, 2021
@lucasfernog lucasfernog deleted the fix/optional-wry-dep branch May 18, 2021 03:42
@6543
Copy link

6543 commented May 18, 2021

thanks for the fix ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants