Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): move api modules behind allowlist feature flags #1864

Merged
merged 3 commits into from
May 19, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Optimizes bundle size and compilation time if you're using the allowlist properly. It may seem like a breaking change, but it's actually a bug fix; the APIs shouldn't be available when the allowlist doesn't allow them.

@lucasfernog lucasfernog requested a review from a team as a code owner May 19, 2021 04:08
@lucasfernog lucasfernog requested review from a team May 19, 2021 04:08
@lucasfernog lucasfernog merged commit aab3e1f into dev May 19, 2021
@lucasfernog lucasfernog deleted the refactor/api-feature-flags branch May 19, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant