Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add run_iteration, parent_window and owner_window APIs, closes #1872 #1874

Merged
merged 4 commits into from
May 21, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner May 20, 2021 00:52
@lucasfernog lucasfernog requested a review from a team May 20, 2021 00:52
@lucasfernog lucasfernog changed the title feat(core): add run_return, parent_window and owner_window APIs, closes #1872 feat(core): add run_iteration, parent_window and owner_window APIs, closes #1872 May 20, 2021
@lucasfernog lucasfernog merged commit 8c0d073 into dev May 21, 2021
@lucasfernog lucasfernog deleted the feat/run-return branch May 21, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants