Skip to content

feat(api): export BaseDirectory in path module#1885

Merged
lucasfernog merged 1 commit intodevfrom
chore/export-base-directory
May 30, 2021
Merged

feat(api): export BaseDirectory in path module#1885
lucasfernog merged 1 commit intodevfrom
chore/export-base-directory

Conversation

@amrbashir
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team as a code owner May 21, 2021 08:18
@amrbashir amrbashir requested a review from a team May 21, 2021 08:19
@amrbashir
Copy link
Member Author

People seemed to always import BaseDirectory rather than Dir and BaseDirectory is more descriptive for its job so I removed the Dir alias

@amrbashir amrbashir force-pushed the chore/export-base-directory branch from 84b53f2 to 148174c Compare May 21, 2021 10:42
@amrbashir amrbashir force-pushed the chore/export-base-directory branch from 148174c to cb38ed3 Compare May 21, 2021 10:43
@amrbashir amrbashir changed the title feat(api): export BaseDirectory in path & remove Dir alias in fs feat(api): export BaseDirectory in path module May 21, 2021
@lucasfernog lucasfernog merged commit 277f5ca into dev May 30, 2021
@lucasfernog lucasfernog deleted the chore/export-base-directory branch May 30, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants