Skip to content

feat(cli.rs): support tauri build on M1 chip #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2021

Conversation

spacemeowx2
Copy link
Contributor

@spacemeowx2 spacemeowx2 commented May 28, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Now, run cargo tauri build on M1 will throw error:

Error: failed to build bundler settings

Caused by:
    Architecture Error: `Unable to determine target-architecture`

This PR resolves the problem.

@spacemeowx2 spacemeowx2 requested a review from a team as a code owner May 28, 2021 12:27
@spacemeowx2 spacemeowx2 requested review from a team May 28, 2021 12:27
@lucasfernog lucasfernog merged commit 3bf853d into tauri-apps:dev May 29, 2021
@spacemeowx2 spacemeowx2 deleted the feature/build-on-m1 branch May 31, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants