Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow dev_path, dist_dir as array of paths, fixes #1897 #1926

Merged
merged 2 commits into from
May 31, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner May 31, 2021 03:42
@lucasfernog lucasfernog requested review from a team May 31, 2021 03:42
@lucasfernog
Copy link
Member Author

The downside of this is that public paths get messy when specifying a file path on the array (currently I just assume it's a root file path). Ideally users should put all their front end assets on a specific folder and point devPath/distDir to that folder, but I agree it's easier to use an array when the frontend is very simple (like most of our examples).

@lucasfernog lucasfernog merged commit 6ec54c5 into dev May 31, 2021
@lucasfernog lucasfernog deleted the feat/dev-path-array branch May 31, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant