fix(core): add hash symbol in uri parse, closes #1943#1947
Conversation
|
Since this PR is touching the Ideally two things should be working:
|
Hash route does not trigger the custom protocol, it is handled by the router framework. Since the hash portion is just an anchor, it doesn't trigger a new page load. |
|
I'll test this anyway. |
|
Works like a charm, tested with a Vue router hash mode app (https://github.com/mayank091193/quasar-scrum) and it didn't affect it since the hash URLs doesn't even hit the custom protocol. |
|
My bad then, I thought directly navigating to a hashed route would still try to go through custom protocol. Thanks for the PR @olegshilov |
What kind of change does this PR introduce? (check at least one)
Described here: #1943
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: