Skip to content

fix(csp): add wss and tauri to conf template #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2021
Merged

fix(csp): add wss and tauri to conf template #1974

merged 2 commits into from
Jun 15, 2021

Conversation

nothingismagick
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

wss is probably more important than ws, and there are reports that we also need to add our custom protocol ;)

@lucasfernog lucasfernog marked this pull request as ready for review June 15, 2021 16:11
@lucasfernog lucasfernog requested a review from a team June 15, 2021 16:11
@nothingismagick nothingismagick requested a review from a team as a code owner June 15, 2021 16:11
@nothingismagick nothingismagick requested a review from a team June 15, 2021 16:11
@lucasfernog lucasfernog merged commit 463fd00 into dev Jun 15, 2021
@lucasfernog lucasfernog deleted the fix/csp branch June 15, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants