Skip to content

fix(windows): run powershell commands without profile #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2021
Merged

fix(windows): run powershell commands without profile #2130

merged 3 commits into from
Jun 30, 2021

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 30, 2021 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team June 30, 2021 16:21
nothingismagick
nothingismagick approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@nothingismagick nothingismagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But don't forget to add a .changes file :)

@amrbashir
Copy link
Member Author

I always forget about those LOL

@amrbashir amrbashir requested a review from a team as a code owner June 30, 2021 16:34
@amrbashir amrbashir requested review from a team June 30, 2021 16:34
@amrbashir amrbashir changed the title fix(cli.rs): run powershell kill command without profile fix(windows): run powershell commands without profile Jun 30, 2021
@lucasfernog lucasfernog merged commit 3e6f341 into dev Jun 30, 2021
@lucasfernog lucasfernog deleted the fix/powershell branch June 30, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nothingismagick nothingismagick nothingismagick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @nothingismagick @lucasfernog