Skip to content

fix(core): improve JS ESM detection - #2139

Merged
lucasfernog merged 1 commit into
devfrom
fix/esm-detection
Jul 2, 2021
Merged

fix(core): improve JS ESM detection#2139
lucasfernog merged 1 commit into
devfrom
fix/esm-detection

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog
lucasfernog requested a review from a team as a code owner July 1, 2021 18:49
@lucasfernog
lucasfernog requested a review from a team July 1, 2021 18:49

@nothingismagick nothingismagick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ok because its just buildtime, and it looks pretty complete

@lucasfernog
lucasfernog merged commit 4b0ec01 into dev Jul 2, 2021
@lucasfernog
lucasfernog deleted the fix/esm-detection branch July 2, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants