fix: center and focus not being allowed in config#2199
Merged
lucasfernog merged 2 commits intotauri-apps:devfrom Jul 12, 2021
FabianLars:fix/window-config
Merged
fix: center and focus not being allowed in config#2199lucasfernog merged 2 commits intotauri-apps:devfrom FabianLars:fix/window-config
lucasfernog merged 2 commits intotauri-apps:devfrom
FabianLars:fix/window-config
Conversation
FabianLars
commented
Jul 12, 2021
| window = window.position(x, y); | ||
| } | ||
|
|
||
| if config.center { |
Member
Author
There was a problem hiding this comment.
This way center overwrites x and y. I don't know if it should do that tho.
| pub fullscreen: bool, | ||
| /// Whether the window will be initially hidden or focused. | ||
| #[serde(default = "default_focus")] | ||
| pub focus: bool, |
Member
Author
There was a problem hiding this comment.
Changing this in tauri.conf.json doesn't seem to make a difference (at least on Windows).
Member
There was a problem hiding this comment.
We decided to remove focus from WindowBuilder and WindowAttributes at Tao, so if tauri wants to support this, they would have to explicitly call window.set_focus().
Member
Author
There was a problem hiding this comment.
Should i remove the focus stuff again? -> Make this pr only about the center thingy?
lucasfernog
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: