Skip to content

Angular create tauri app [#1934] - #2203

Merged
lemarier merged 5 commits into
tauri-apps:devfrom
Calciumdibromid:angular-create-tauri-app
Jul 14, 2021
Merged

Angular create tauri app [#1934]#2203
lemarier merged 5 commits into
tauri-apps:devfrom
Calciumdibromid:angular-create-tauri-app

Conversation

@Epsilon02

@Epsilon02 Epsilon02 commented Jul 12, 2021

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
closes #1934

@Epsilon02
Epsilon02 requested a review from a team as a code owner July 12, 2021 15:57
@lucasfernog

Copy link
Copy Markdown
Member

Looks good, can you add a change file (a markdown file on the .changes folder)? Contents like this:

---
"create-tauri-app": patch
---

Added Angular CLI recipe.

@Epsilon02

Copy link
Copy Markdown
Contributor Author

Done.
I used your suggestion because it fit.

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, thanks for your efforts, can you add some tests in tooling/create-tauri-app/test/index.spec.ts and add the recipe to the list of recipes in .github/workflows/test-cta.yml ?

@Epsilon02
Epsilon02 requested a review from a team July 12, 2021 19:25
@Epsilon02

Copy link
Copy Markdown
Contributor Author

Hmm do I have something to do to get the tests passed? 🤔

@nothingismagick

Copy link
Copy Markdown
Member

The error is quite strange. I just reran the tests, let's see what happens.

@nothingismagick

Copy link
Copy Markdown
Member

Hmm, this is super strange. Have to pull in the heavyweights. @jbolda & @rajivshah3 - have you guys ever seen git fail like this in a workflow?

@lemarier

Copy link
Copy Markdown
Member

@Epsilon02 can you merge with dev please? (I don't seem to have access to your PR)
It should be fixed.

Thanks!

@lemarier

Copy link
Copy Markdown
Member

Hi @Epsilon02,

Thanks for your contribution we do appreciate it a lot.

Looks like the action never really run successfully as seen here;
https://github.com/tauri-apps/tauri/actions/workflows/test-cta.yml

@jbolda I think this is for you ;) ☝️

LGTM as it should be handled in another PR

@lemarier
lemarier merged commit 489fad5 into tauri-apps:dev Jul 14, 2021
@Epsilon02

Copy link
Copy Markdown
Contributor Author

Hi @lemarier
I am happy it is finally merged.

@Epsilon02
Epsilon02 deleted the angular-create-tauri-app branch July 14, 2021 20:49
@lemarier

Copy link
Copy Markdown
Member

@Epsilon02

We should release in the upcoming days! Stay tuned ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular recipe for create-tauri-app

5 participants