Skip to content

fix(api.js): fix @ts-expect-error usage, closes #2249#2250

Merged
lemarier merged 2 commits intodevfrom
fix/api-ts-expect-error
Jul 19, 2021
Merged

fix(api.js): fix @ts-expect-error usage, closes #2249#2250
lemarier merged 2 commits intodevfrom
fix/api-ts-expect-error

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 19, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team July 19, 2021 19:25
@amrbashir amrbashir requested a review from a team as a code owner July 19, 2021 19:26
@Laegel
Copy link
Member

Laegel commented Jul 19, 2021

Oh thanks @amrbashir , we had this issue when running the update-docs workflow.

@lemarier lemarier merged commit dd52e73 into dev Jul 19, 2021
@lemarier lemarier deleted the fix/api-ts-expect-error branch July 19, 2021 22:20
@kubijo
Copy link

kubijo commented Jul 21, 2021

I was just about to report these since our tsc / CI fails on this, so great to see it's fixed already .... do you have any idea / plans on a release date that should include it?

@amrbashir
Copy link
Member Author

amrbashir commented Jul 21, 2021

Since we just did a release recently, it might take a while to do another one but I am not the one responsible for releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants