Skip to content

fix(core): Expose ClipboardManager and GlobalShortcutManager #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

lemarier
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lemarier lemarier requested a review from a team as a code owner July 20, 2021 17:49
@lemarier lemarier requested a review from a team July 20, 2021 17:49
@lemarier
Copy link
Member Author

@chippers @lucasfernog not sure if its the best thing to do here, but with the PR #2262 we got access to the apphandler, and then we can get the global_shortcut_manager but if we don't import GlobalShortcutManager we don't have access to the impl, and is not exported right now.

@lemarier lemarier mentioned this pull request Jul 23, 2021
13 tasks
@lucasfernog lucasfernog merged commit 6e0dbf6 into dev Aug 3, 2021
@lucasfernog lucasfernog deleted the fix/expose-apphandler-manager branch August 3, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants