Add svelte recipe to create-tauri-app (#2276) - #2279
Merged
Conversation
amrbashir
requested changes
Jul 22, 2021
amrbashir
left a comment
amrbashir
left a comment
Member
There was a problem hiding this comment.
Well done, thanks for your contribution, just small nitpicks and this PR is ready to go.
* Fix Svelte template URL * Add beforeBuildCommand and beforeDevCommand * Improve postInit log message
Member
|
don't forget to run |
Member
|
sorry, one more thing, can you add a change file in .changes folder, ---
"create-tauri-app": patch
---
Add Svelte recipe using the official template. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Implementing #2276