Skip to content

fix(api.js): fix double window creation, closes #2284#2285

Merged
lemarier merged 1 commit intodevfrom
fix/double-window-api
Jul 23, 2021
Merged

fix(api.js): fix double window creation, closes #2284#2285
lemarier merged 1 commit intodevfrom
fix/double-window-api

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 23, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested a review from a team as a code owner July 23, 2021 10:17
@amrbashir amrbashir requested a review from a team July 23, 2021 10:17
@amrbashir amrbashir changed the title fix(api.js): fix double window creation fix(api.js): fix double window creation, closes #2284 Jul 23, 2021
@amrbashir amrbashir force-pushed the fix/double-window-api branch from 835e990 to 43e81e2 Compare July 23, 2021 10:20
@amrbashir amrbashir added the scope: api.js The @tauri-apps/api npm package label Jul 23, 2021
@lemarier lemarier merged commit 9fbcc02 into dev Jul 23, 2021
@lemarier lemarier deleted the fix/double-window-api branch July 23, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: api.js The @tauri-apps/api npm package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants