Skip to content

convert jest tests to child_process run script - #2308

Merged
jbolda merged 14 commits into
devfrom
switch-cta-tests-to-script
Aug 8, 2021
Merged

convert jest tests to child_process run script#2308
jbolda merged 14 commits into
devfrom
switch-cta-tests-to-script

Conversation

@jbolda

@jbolda jbolda commented Jul 28, 2021

Copy link
Copy Markdown
Member

Motivation

The current set of jest based tests seem to be fragile, and failure occurrences invariably do not provide enough information to debug. In reality, we just want to invoke and run CTA and check the state of fs afterwards. This switches to a pure script with a bit of Github Action log collapsing to make it easy to see exactly what is running and the return.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor (tests)
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@jbolda
jbolda force-pushed the switch-cta-tests-to-script branch 3 times, most recently from 56919b8 to a709134 Compare July 31, 2021 07:02
@amrbashir
amrbashir force-pushed the switch-cta-tests-to-script branch from 787c4b3 to 24ca318 Compare July 31, 2021 15:52
@jbolda
jbolda force-pushed the switch-cta-tests-to-script branch from d71c214 to dea30a4 Compare August 3, 2021 07:06
@jbolda
jbolda force-pushed the switch-cta-tests-to-script branch from 6cd05ff to 4a171aa Compare August 7, 2021 05:54
@jbolda
jbolda marked this pull request as ready for review August 7, 2021 05:54
@jbolda
jbolda requested a review from a team as a code owner August 7, 2021 05:55
@jbolda
jbolda requested review from a team August 7, 2021 05:55
@jbolda
jbolda merged commit c410e03 into dev Aug 8, 2021
@jbolda
jbolda deleted the switch-cta-tests-to-script branch August 8, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants