convert jest tests to child_process run script - #2308
Merged
Conversation
jbolda
force-pushed
the
switch-cta-tests-to-script
branch
3 times, most recently
from
July 31, 2021 07:02
56919b8 to
a709134
Compare
amrbashir
force-pushed
the
switch-cta-tests-to-script
branch
from
July 31, 2021 15:52
787c4b3 to
24ca318
Compare
jbolda
force-pushed
the
switch-cta-tests-to-script
branch
from
August 3, 2021 07:06
d71c214 to
dea30a4
Compare
13 tasks
jbolda
force-pushed
the
switch-cta-tests-to-script
branch
from
August 7, 2021 05:54
6cd05ff to
4a171aa
Compare
jbolda
marked this pull request as ready for review
August 7, 2021 05:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current set of jest based tests seem to be fragile, and failure occurrences invariably do not provide enough information to debug. In reality, we just want to invoke and run CTA and check the state of fs afterwards. This switches to a pure script with a bit of Github Action log collapsing to make it easy to see exactly what is running and the return.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: