Skip to content

feat(CTA): add official support for pnpm package manager - #2348

Merged
wusyong merged 3 commits into
devfrom
feat/cta/pnpm-support
Aug 6, 2021
Merged

feat(CTA): add official support for pnpm package manager#2348
wusyong merged 3 commits into
devfrom
feat/cta/pnpm-support

Conversation

@amrbashir

@amrbashir amrbashir commented Aug 4, 2021

Copy link
Copy Markdown
Member

I didn't add any pnpm tests cause I think volta doesn't support pnpm yet volta-cli/volta#737 (comment) and since pnpm users are not that many we can add pnpm tests later.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir
amrbashir requested a review from a team as a code owner August 4, 2021 00:31
@amrbashir amrbashir changed the title feat(CTA): add official support for pnpm feat(CTA): add official support for pnpm package manager Aug 4, 2021
@amrbashir
amrbashir force-pushed the feat/cta/pnpm-support branch from 4248afe to 384dd4b Compare August 4, 2021 00:37
@amrbashir

amrbashir commented Aug 4, 2021

Copy link
Copy Markdown
Member Author

Alright I think this PR is done and it should be merged before #2308, due to changes in checking package managers in e8f1141

@wusyong
wusyong merged commit 235e0f6 into dev Aug 6, 2021
@wusyong
wusyong deleted the feat/cta/pnpm-support branch August 6, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants