Skip to content

fix(updater): Run elevated task only if server tell us#2357

Merged
lucasfernog merged 2 commits into
devfrom
fix/updater-no-elevated-task
Aug 8, 2021
Merged

fix(updater): Run elevated task only if server tell us#2357
lucasfernog merged 2 commits into
devfrom
fix/updater-no-elevated-task

Conversation

@lemarier
Copy link
Copy Markdown
Member

@lemarier lemarier commented Aug 4, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fix #2356

PS: It'll not run if the task is not installed, but it allows the customer to toggle if something appends.

PS: It'll not run if the task is not installed, but it allow the customer to toggle if something append.
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier lemarier requested a review from a team as a code owner August 4, 2021 21:41
@lemarier lemarier requested a review from a team August 4, 2021 21:41
@lucasfernog lucasfernog merged commit c576119 into dev Aug 8, 2021
@lucasfernog lucasfernog deleted the fix/updater-no-elevated-task branch August 8, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updater: MSI is not starting without UAC

2 participants