Skip to content

fix(core): fixes ES Module detection for default imports with relative paths or scoped packages#2380

Merged
lucasfernog merged 3 commits into
tauri-apps:devfrom
FabianLars:patch-1
Aug 10, 2021
Merged

fix(core): fixes ES Module detection for default imports with relative paths or scoped packages#2380
lucasfernog merged 3 commits into
tauri-apps:devfrom
FabianLars:patch-1

Conversation

@FabianLars

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@FabianLars FabianLars requested a review from a team as a code owner August 10, 2021 13:04
@FabianLars FabianLars requested a review from a team August 10, 2021 13:04
Comment thread core/tauri-codegen/src/embedded_assets.rs Outdated
@lucasfernog lucasfernog merged commit b2b36cf into tauri-apps:dev Aug 10, 2021
@FabianLars FabianLars deleted the patch-1 branch August 19, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants