Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler): check target arch at runtime, closes #2286 #2422

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner August 13, 2021 16:37
@lucasfernog lucasfernog requested a review from a team August 13, 2021 16:37
@lucasfernog
Copy link
Member Author

I don't have a macOS M1 to test this but it should fix #2286.

@lucasfernog lucasfernog changed the title feat(bundler): check target arch at compile time, closes #2286 feat(bundler): check target arch at runtime, closes #2286 Aug 13, 2021
@lucasfernog lucasfernog merged commit 5ebf389 into dev Aug 13, 2021
@lucasfernog lucasfernog deleted the feat/compile-time-target-arch branch August 13, 2021 21:05
@chrisspiegl
Copy link

I am wondering if this is already in the public release.
I am using @tauri-apps/cli@1.0.0-beta.10 and it's still behaving as before.
But I also can't seem to test since the current stuff on github is not release to npm at all and I have not yet found a way to get the repository installed via git links in my package.json.

@FabianLars
Copy link
Member

@chrisspiegl It should be yes, make sure it actually resolves to beta.10 in your lock file.
For testing the unreleased stuff see my answer to your comment in #2510.

via git links in my package.json

As mentioned in the other issue that wouldn't help you anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants