Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bundler): use linuxdeploy instead of appimagetool, closes #1986 #2437

Merged
merged 5 commits into from
Aug 15, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner August 15, 2021 19:38
@lucasfernog lucasfernog requested review from a team August 15, 2021 19:38
@lucasfernog lucasfernog merged commit 397710b into dev Aug 15, 2021
@lucasfernog lucasfernog deleted the refactor/linuxdeploy branch August 15, 2021 20:09
@guillemcordoba
Copy link
Contributor

Hey! Thanks for this :) Is there some way we can use this before it getting released? Pointing to it in the github repo didn't seem to work.

@lucasfernog
Copy link
Member Author

You can follow the CONTRIBUTION.md file that we have on this repo.

@lucasfernog
Copy link
Member Author

I love inception btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants