Skip to content

feat(core): set parent window on ask and message dialog APIs#2454

Merged
lucasfernog merged 4 commits into
devfrom
feat/ask-message-parent
Aug 16, 2021
Merged

feat(core): set parent window on ask and message dialog APIs#2454
lucasfernog merged 4 commits into
devfrom
feat/ask-message-parent

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner August 16, 2021 19:23
@lucasfernog lucasfernog requested review from a team August 16, 2021 19:23
@lucasfernog lucasfernog changed the title feat(core): set parent window on ask, message dialog APIs feat(core): set parent window on ask and message dialog APIs Aug 16, 2021
@lucasfernog lucasfernog merged commit c76f4b7 into dev Aug 16, 2021
@lucasfernog lucasfernog deleted the feat/ask-message-parent branch August 16, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant