Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: custom protocol #2503

Merged
merged 16 commits into from
Aug 23, 2021
Merged

refactor: custom protocol #2503

merged 16 commits into from
Aug 23, 2021

Conversation

lemarier
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

lucasfernog and others added 3 commits August 11, 2021 15:14
@lucasfernog
refactor(core): register URI protocol once, remove from WebviewAttrib…
e9f877a 
…utes
@lemarier
refactor: Custom protocol
1a6991d 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
make clippy happy
95abccd 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
Copy link
Member Author

lemarier commented Aug 20, 2021 •
edited
Loading

ATTENTION! It use wry dev branch.

DO NOT MERGE.

@lemarier
fix dialog error
3b3b5c1 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
add complete example
83935b3 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
cleanup
179b3d4 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
fix mp4 test
fc024dd 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
fix http response tests
eafc0bc 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
fix windows example
36007ff 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
implement basic form post in api example
5110f75 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
[ci skip] update mimetype
06c9fb5 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier
bump to wry dev branch
aca6eda 
Signed-off-by: David Lemarier <david@lemarier.ca>
@lemarier lemarier marked this pull request as ready for review August 23, 2021 13:23
@lemarier lemarier requested a review from a team as a code owner August 23, 2021 13:23
@lemarier lemarier requested review from a team August 23, 2021 13:23
@lucasfernog lucasfernog merged commit 539e448 into dev Aug 23, 2021
@lucasfernog lucasfernog deleted the feat/protocol-refactor branch August 23, 2021 14:09
lucasfernog added a commit that referenced this pull request Aug 26, 2021
@krscott @lemarier
@lucasfernog @github-actions @chippers
Fix svelte recipe packageManager ternary (#2534)
e706df7 
* refactor: custom protocol (#2503)

Co-authored-by: Lucas Nogueira <lucas@tauri.studio>

* Apply Version Updates From Current Changes (#2513)

Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>

* fix(api): revert ES2021 target

* Apply Version Updates From Current Changes (#2520)

Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>

* docs: webdriver guide (#2461)

Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <wusyong9104@gmail.com>

* fix(core): `Notification.requestPermission()` deadlock regression

* Fix packageManager ternary

Co-authored-by: david <david@lemarier.ca>
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
Co-authored-by: chip <chip@chip.sh>
Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <wusyong9104@gmail.com>
lucasfernog added a commit that referenced this pull request Aug 26, 2021
@grey4owl @lemarier
@lucasfernog @github-actions @chippers
fix(examples): API example with npm, closes #2470 (#2536)
774b8a1 
* refactor: custom protocol (#2503)

Co-authored-by: Lucas Nogueira <lucas@tauri.studio>

* Apply Version Updates From Current Changes (#2513)

Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>

* fix(api): revert ES2021 target

* Apply Version Updates From Current Changes (#2520)

Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>

* docs: webdriver guide (#2461)

Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <wusyong9104@gmail.com>

* fix(core): `Notification.requestPermission()` deadlock regression

* Update package.json

Small typo in path..

* update lockfile [skip ci]

Co-authored-by: david <david@lemarier.ca>
Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
Co-authored-by: chip <chip@chip.sh>
Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <wusyong9104@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonbrugman ramonbrugman ramonbrugman approved these changes

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemarier @lucasfernog @ramonbrugman