Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update cli.yml to pass clap ArgSettings::MultipleValues assertion. (#2506) #2507

Merged

Conversation

edgex004
Copy link
Contributor

@edgex004 edgex004 commented Aug 21, 2021

ArgSettings::TakesValue is required when ArgSettings::MultipleValues is set.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fixes #2507

David Von Edge added 2 commits August 21, 2021 12:41
ArgSettings::TakesValue is required when ArgSettings::MultipleValues is set.
@edgex004 edgex004 requested a review from a team as a code owner August 21, 2021 20:00
@edgex004 edgex004 requested a review from a team August 21, 2021 20:00
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@lucasfernog lucasfernog merged commit 0391ac3 into tauri-apps:dev Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants