refactor(cta): use commander instead of minimst - #2551
Merged
Conversation
Member
Author
|
alright, checks have passed, I guess this PR is ready to go |
amrbashir
force-pushed
the
refactor/cta/use-commander
branch
from
August 30, 2021 09:20
7477422 to
1399ad2
Compare
nothingismagick
approved these changes
Aug 31, 2021
nothingismagick
left a comment
Member
There was a problem hiding this comment.
I will approve this, but would really like to recommend that you take the time to fill out the template of the PR and give non-informed readers (aka those not reading every channel on discord) justification for replacing functionality. This is also useful for posterity.
Member
Author
|
yeah that's totally my bad, I think I forgot |
amrbashir
marked this pull request as draft
September 22, 2021 14:34
Member
Author
|
I marked this as a draft as I think I still need to do some changes to this PR before merge. |
Member
Author
|
alright this is ready, but probably need to be merged after the audit as it introduces a new dependency. |
amrbashir
marked this pull request as ready for review
September 30, 2021 12:26
amrbashir
marked this pull request as draft
November 30, 2021 14:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
commanderis more robust thanminimst, two main features I appreciate is: