Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler) wix template escape character #2608

Merged
merged 3 commits into from
Sep 21, 2021
Merged

fix(bundler) wix template escape character #2608

merged 3 commits into from
Sep 21, 2021

Conversation

ioneyed
Copy link
Contributor

@ioneyed ioneyed commented Sep 15, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

Other information:

An escape character is being recognized instead of the replacement pattern for variables in the WIX template.

Given:

manufacturer = acme
product_name = anvil

Current Registry Result:
Computer\HKEY_CURRENT_USER\Software{{{manufacturer}}}{{{product_name}}}

Expected Registry Result
Computer\HKEY_CURRENT_USER\Software\acme\anvil

An escape character is being recognized instead of the replacement pattern for variables in the WIX template.

Given:

manufacturer = acme
product_name = anvil

Current Registry Result:
`Computer\HKEY_CURRENT_USER\Software{{{manufacturer}}}{{{product_name}}}`

Expected Registry Result
`Computer\HKEY_CURRENT_USER\Software\acme\anvil`
@ioneyed ioneyed changed the title WIP: fix(bundler) wix template escape character fix(bundler) wix template escape character Sep 15, 2021
@ioneyed ioneyed marked this pull request as ready for review September 15, 2021 18:16
@ioneyed ioneyed requested a review from a team September 15, 2021 18:16
@ioneyed ioneyed requested a review from a team as a code owner September 21, 2021 15:11
@lucasfernog lucasfernog merged commit 2be1abd into tauri-apps:next Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants