Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to edition 2021 and set minimum rust to 1.56 #2789

Merged
merged 3 commits into from
Oct 22, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner October 22, 2021 12:22
@lucasfernog lucasfernog requested review from a team October 22, 2021 12:22
@wusyong
Copy link
Member

wusyong commented Oct 22, 2021

With Minimum Supported Rust Version is finally available, we could remove rust-toolchain file.
Our minimum version would be 1.56 until next edition comes out hopefully.

@lucasfernog
Copy link
Member Author

With Minimum Supported Rust Version is finally available, we could remove rust-toolchain file. Our minimum version would be 1.56 until next edition comes out hopefully.

Yeah that's the plan. I removed the file on this PR.

@lucasfernog lucasfernog merged commit a9dfc01 into next Oct 22, 2021
@lucasfernog lucasfernog deleted the feat/rust-1.56 branch October 22, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants