You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If adding a new feature, the PR's description includes:
A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
Other information:
This is a follow-up to tauri-apps/tao#240 and tauri-apps/wry#446. I'm updating the windows crate to 0.25.0 (which comes with pre-compiled libraries that implement the bindings without needing to reference webview2-com directly for built-in types), and webview2-com 0.7.0, which also depends on that version of windows.
I found one lingering reference to winapi in cli.rs. I was going to replace it with the equivalent pre-compiled libraries from windows, but it doesn't seem to be used anywhere, so I removed it.
It looks like the updater test failed on windows-latest because the cached Git checkout (.cargo/git/...) for WRY was out of date. Normally I'd fix that locally by re-running cargo update. I'll see if I can add that step to the workflow.
The other two failures in test-tauri-js-cli are both timeouts while compiling with rustc. If it happened in just windows-latest I'd be worried that this change dramatically increased the build time, but it happened in the macos-latest run as well. I think the timeouts just need to be increased in the Jest test.
It looks like the updater test failed on windows-latest because the cached Git checkout (.cargo/git/...) for WRY was out of date. Normally I'd fix that locally by re-running cargo update. I'll see if I can add that step to the workflow.
Weird, the examples/api/src-tauri/Cargo.toml and examples/api/package.json don't seem to do anything different from examples/updater, but for some reason examples/updater is pulling a different version of tao, windows, and webview2-com* through the dependency in wry. The api example works and the updater example doesn't.
I saw the same build failure on my local repo for updater, and cargo update didn't fix it. Neither did cargo clean. Other than adding a patch table to Cargo.toml, I'm not sure how to fix this.
I saw the same build failure on my local repo for updater, and cargo update didn't fix it. Neither did cargo clean. Other than adding a patch table to Cargo.toml, I'm not sure how to fix this.
OK, I think I fixed it. I was running cargo update from examples/updater rather than examples/updater/src-tauri. I also needed to update Cargo.lock in examples/api to point back to the upstream next branch for wry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This is a follow-up to tauri-apps/tao#240 and tauri-apps/wry#446. I'm updating the
windowscrate to 0.25.0 (which comes with pre-compiled libraries that implement the bindings without needing to referencewebview2-comdirectly for built-in types), andwebview2-com0.7.0, which also depends on that version ofwindows.I found one lingering reference to
winapiincli.rs. I was going to replace it with the equivalent pre-compiled libraries fromwindows, but it doesn't seem to be used anywhere, so I removed it.