fix(tauri-build): allow user to specify win sdk path (fix: #2871) - #2893
Merged
Conversation
Contributor
Author
|
For your information. I tested this in the tauri getting started by editing use tauri_build::{try_build, Attributes, WindowsAttributes};
fn main() {
if let Err(error) = try_build(Attributes::new().windows_attributes(
WindowsAttributes::new().sdk_dir("C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x64/")
)) {
panic!("error found during tauri-build: {}", error);
}
}I also ran cargo test and there were no errors. |
Member
|
Can you add a change file? It is a markdown file on the ---
"tauri-build": patch
---
...The change description that will be pushed to the changelog |
Contributor
Author
|
@lucasfernog Done |
Member
|
Thanks for this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2871 by allowing users to pass in the sdk_path (windows only) when it can otherwise not be found.
What kind of change does this PR introduce? (check at least one)
This is a fix because I need this to get the builds to work on my machine. Some may consider this a new feature that allows for greater flexibility.
Does this PR introduce a breaking change? (check one)
If the new parameter is not specified, the old methods of resolving the path are taken.
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: