refactor(cli.rs): signer and plugin subcommands, use new clap derive syntax#2928
Merged
lucasfernog merged 12 commits intonextfrom Dec 9, 2021
Merged
refactor(cli.rs): signer and plugin subcommands, use new clap derive syntax#2928lucasfernog merged 12 commits intonextfrom
signer and plugin subcommands, use new clap derive syntax#2928lucasfernog merged 12 commits intonextfrom
Conversation
refactor(cli.rs): use functions and trait impls instead of structs update deps fmt
signer and plugin subcommands, use new clap derive syntax
Member
|
@JonasKruckenberg I'll merge this PR because we need the clap update and it's a huge refactor already. If you're still interested in doing the other tasks, please open a new PR :) thanks for this amazing work, it really helped migrating to clap 3.0.0-rc.0 |
Member
Author
|
Yes it's good to merge as is, I got stuck with the more involved features (that's in part where #3029 originated from) but that will have to continue on a separate branch anyway so 👍🏻 from me |
This was referenced Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces runner structs with option structs that implement
From<&ArgMatches>/TryFrom<ArgMatches>to clean things up a bit. This makes the code structure more scaleable imo.This also splits the
tauri signsubcommand into two:tauri signer signandtauri signer generate.TODO:
tauri plugin addsubcommandtauri buildtauri devtauri signertauri plugin initNotes to self:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: