-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli.rs): signer
and plugin
subcommands, use new clap derive syntax
#2928
Conversation
refactor(cli.rs): use functions and trait impls instead of structs update deps fmt
signer
and plugin
subcommands, use new clap derive syntax
@JonasKruckenberg I'll merge this PR because we need the clap update and it's a huge refactor already. If you're still interested in doing the other tasks, please open a new PR :) thanks for this amazing work, it really helped migrating to clap 3.0.0-rc.0 |
Yes it's good to merge as is, I got stuck with the more involved features (that's in part where #3029 originated from) but that will have to continue on a separate branch anyway so 👍🏻 from me |
Replaces runner structs with option structs that implement
From<&ArgMatches>
/TryFrom<ArgMatches>
to clean things up a bit. This makes the code structure more scaleable imo.This also splits the
tauri sign
subcommand into two:tauri signer sign
andtauri signer generate
.TODO:
tauri plugin add
subcommandtauri build
tauri dev
tauri signer
tauri plugin init
Notes to self:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: