Skip to content

feat(core): add Menu::with_items, closes #2807#2966

Merged
lucasfernog merged 1 commit into
nextfrom
feat/menu-taking-vec
Dec 27, 2021
Merged

feat(core): add Menu::with_items, closes #2807#2966
lucasfernog merged 1 commit into
nextfrom
feat/menu-taking-vec

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner November 25, 2021 18:12
@lucasfernog lucasfernog requested review from a team November 25, 2021 18:12
Comment thread docs/usage/guides/visual/menu.md
@probablykasper

probablykasper commented Dec 23, 2021

Copy link
Copy Markdown
Member

Made PR #3105 which goes further on what was suggested in #2807

@lucasfernog lucasfernog merged commit 7cc95e1 into next Dec 27, 2021
@lucasfernog lucasfernog deleted the feat/menu-taking-vec branch December 27, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants