fix(cli.js): Fix package installation on yarn 2+#3012
Merged
lucasfernog merged 2 commits intonextfrom Dec 9, 2021
Merged
Conversation
amrbashir
approved these changes
Dec 2, 2021
lucasfernog
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yarn 2+ uses pnp by default. This makes installed npm packages read-only by default. This will obviously break the rust-cli download. To fix this we need yarn to
unplugour cli. We can either tell the user to do that after each installation (lol no) or tell yarn to do it automatically by specifying a "postinstall" script. This script can be empty too so we don't have to go through the hassle of rewriting our download script to actually happen at postinstall time. Who knows what new issues this will create 😅In theory this would close some gh issues, but they are already closed lol.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes: