Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler): configure WiX to add launch option, closes #3015 #3043

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner December 7, 2021 19:58
@lucasfernog lucasfernog requested a review from a team December 7, 2021 19:58
@lucasfernog lucasfernog merged commit feb3a8f into next Dec 9, 2021
@lucasfernog lucasfernog deleted the feat/wix-run-app branch December 9, 2021 04:27
@xuchaoqian
Copy link
Contributor

It works during the process of installation, but does not work during the process of update. It launches the previous version after update if I change the code of updater:

      Command::new("msiexec.exe")
        .arg("/i")
        .arg(found_path)
        .arg("/qf")   // change qb+ to qf to allow to set launch option
        .spawn()
        .expect("installer failed to start");

@lucasfernog
Copy link
Member Author

Can you file another issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants