feat(bundler): initialize msi install path with previous location#3158
Merged
lucasfernog merged 2 commits intonextfrom Jan 7, 2022
Merged
feat(bundler): initialize msi install path with previous location#3158lucasfernog merged 2 commits intonextfrom
lucasfernog merged 2 commits intonextfrom
Conversation
lucasfernog
reviewed
Jan 5, 2022
Member
lucasfernog
left a comment
There was a problem hiding this comment.
could use a change file here
Member
Author
|
should it mention the registry key too or is this enough? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we now save the installation directory to the registry and use that value to initialize the default install dir on following installations (upgrades).
This was requested a few times so that tauri's buit-in updater doesn't default to
C:\Program Files\app_name(ofc useful for manual update-installations too).The default path if the reg key doesn't exist is the same as before.
I intentionally added the reg value stuff in a separate
Component(for clarity) and inside aRegistryKeyobject (for extensibility).With this change i also changed
manufacturerto be the middle part of the bundle identifier instead of the whole thing. This was imho just plain wrong.The whole bundle identifier is still used as the
AppId, mainly because notifications don't work without it.Furthermore I changed the dummy registry values used as keyPaths for the shortcuts to be all in the same registry "folder".
Instead of having an
installedkey in 3 locations, we now have 3 different (dummy) keys in the same path, much cleaner imo.Just to be extra clear, this is not a breaking change. New installers are still compatible with previous ones. Upgrading old installations with the new installer works normally (old reg keys will be removed by the old uninstaller).
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix #___, #___)