Skip to content

Consistent event name usage#3228

Merged
lucasfernog merged 2 commits intonextfrom
consistent-event-name-usage
Jan 15, 2022
Merged

Consistent event name usage#3228
lucasfernog merged 2 commits intonextfrom
consistent-event-name-usage

Conversation

@JonasKruckenberg
Copy link
Copy Markdown
Member

Makes the Event interface use the EventName type for the event field instea of string

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

https://discord.com/channels/616186924390023171/731495028677148753/931986520871690331

Makes the `Event` interface use the `EventName` type for the `event` field instea of `string`
@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner January 15, 2022 19:16
@JonasKruckenberg JonasKruckenberg requested a review from a team January 15, 2022 19:16
@JonasKruckenberg JonasKruckenberg added the scope: api.js The @tauri-apps/api npm package label Jan 15, 2022
@lucasfernog lucasfernog merged commit b5d9bcb into next Jan 15, 2022
@lucasfernog lucasfernog deleted the consistent-event-name-usage branch January 15, 2022 20:47
@JonasKruckenberg
Copy link
Copy Markdown
Member Author

Is the failing build on windows already know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: api.js The @tauri-apps/api npm package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants