Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler): support building AppImage without FUSE #3259

Merged
merged 4 commits into from
Jan 21, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner January 21, 2022 17:50
@lucasfernog lucasfernog requested review from a team January 21, 2022 17:50
@FabianLars
Copy link
Member

For what it's worth, shellcheck isn't happy with this change. But i guess the output of lsmod is not too bad for this to really matter.

@lucasfernog
Copy link
Member Author

We'll resolve other lint issues next week.

@lucasfernog lucasfernog merged commit 28dd9ad into next Jan 21, 2022
@lucasfernog lucasfernog deleted the fix/appimage-fuse branch January 21, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants