Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wix installer is also signed #3266

Merged
merged 5 commits into from
Jan 23, 2022

Conversation

Niedzwiedzw
Copy link
Contributor

@Niedzwiedzw Niedzwiedzw commented Jan 22, 2022

What kind of change does this PR introduce?

Signing a binary that goes into wix is great, but end user will still experience a malware warning unless the wix installer itself is also signed.

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@Niedzwiedzw Niedzwiedzw requested a review from a team January 22, 2022 19:07
@Niedzwiedzw Niedzwiedzw force-pushed the feat/sign-wix-msi-installer branch from f4c1389 to e3facc7 Compare January 22, 2022 19:09
@lucasfernog
Copy link
Member

Can you add a .md file on the .changes folder describing this change, so it can be added to the changelog? Like this:

.changes/wix-signing.md

---
"tauri-bundler": patch
---

Sign WiX installer in addition to the executable file.

@Niedzwiedzw Niedzwiedzw requested a review from a team as a code owner January 22, 2022 19:25
@lucasfernog lucasfernog merged commit d801cc8 into tauri-apps:next Jan 23, 2022
@ImmaZoni
Copy link
Contributor

I was trying to fix this, glad you beat me to the punch!

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants