wix installer is also signed#3266
Merged
lucasfernog merged 5 commits intoJan 23, 2022
Merged
Conversation
f4c1389 to
e3facc7
Compare
Member
|
Can you add a .changes/wix-signing.md ---
"tauri-bundler": patch
---
Sign WiX installer in addition to the executable file. |
|
I was trying to fix this, glad you beat me to the punch! Thanks a bunch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Signing a binary that goes into wix is great, but end user will still experience a malware warning unless the wix installer itself is also signed.
Does this PR introduce a breaking change?
Checklist
fix #___, #___)Other information