Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3288: Add provider_short_name for macOS #3289

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix #3288: Add provider_short_name for macOS #3289

merged 1 commit into from
Jan 27, 2022

Conversation

swissmanu
Copy link
Contributor

Fixes #3288

What kind of change does this PR introduce?

Allow to provide a provider short name, so macOS apps can be notarized using developer accounts connected to multiple teams.

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@swissmanu swissmanu requested a review from a team as a code owner January 27, 2022 06:48
@swissmanu swissmanu requested review from a team January 27, 2022 06:48
@swissmanu
Copy link
Contributor Author

Thanks @FabianLars for guiding me to this change :) https://discord.com/channels/616186924390023171/731495105034321962/935979812210737214

@swissmanu swissmanu mentioned this pull request Jan 27, 2022
Closed
@swissmanu swissmanu changed the title Fix #3288: Add prvider_short_name for macOS Fix #3288: Add provider_short_name for macOS Jan 27, 2022
@lucasfernog
Copy link
Member

Perfect work :)

@lucasfernog lucasfernog merged commit 8ab8d52 into tauri-apps:next Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Cannot notarize macOS App while having a developer account connected to multiple teams
2 participants
@swissmanu @lucasfernog