Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add universal-darwin-macos build target, closes #3317 #3318

Merged
merged 5 commits into from
Feb 4, 2022

Conversation

betamos
Copy link
Contributor

@betamos betamos commented Feb 1, 2022

See #3317.

This is my first PR so I may have missed something (despite the checklist).

Note that external binaries are not addressed yet, see issue for discussion. Also, docs are missing - I'll add those once the approach is approved.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

TODO: Docs, external binaries
@betamos betamos requested review from a team February 1, 2022 21:42
@lucasfernog
Copy link
Member

Nice work, I'll fix the merge conflict and test it now.

@lucasfernog lucasfernog changed the title MVP: Add universal-darwin-macos build target, closes #3317 feat: Add universal-darwin-macos build target, closes #3317 Feb 4, 2022
@betamos betamos requested a review from a team as a code owner February 4, 2022 21:41
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only missed the change file and would be good if you had your commits signed too, but this was an amazing PR! Thank you ❤️

@lucasfernog lucasfernog merged commit 83f52fd into tauri-apps:next Feb 4, 2022
@betamos
Copy link
Contributor Author

betamos commented Feb 7, 2022

Thanks! Note that sidecar still doesn't work with universal but I'll send out another one for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants