feat: Add universal-darwin-macos build target, closes #3317#3318
Merged
lucasfernog merged 5 commits intotauri-apps:nextfrom Feb 4, 2022
Merged
feat: Add universal-darwin-macos build target, closes #3317#3318lucasfernog merged 5 commits intotauri-apps:nextfrom
universal-darwin-macos build target, closes #3317#3318lucasfernog merged 5 commits intotauri-apps:nextfrom
Conversation
TODO: Docs, external binaries
Member
|
Nice work, I'll fix the merge conflict and test it now. |
lucasfernog
changed the title
universal-darwin-macos build target, closes #3317universal-darwin-macos build target, closes #3317
lucasfernog
approved these changes
Feb 4, 2022
Member
lucasfernog
left a comment
lucasfernog
left a comment
There was a problem hiding this comment.
You only missed the change file and would be good if you had your commits signed too, but this was an amazing PR! Thank you ❤️
Contributor
Author
|
Thanks! Note that sidecar still doesn't work with universal but I'll send out another one for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3317.
This is my first PR so I may have missed something (despite the checklist).
Note that external binaries are not addressed yet, see issue for discussion. Also, docs are missing - I'll add those once the approach is approved.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information