Expose event interface. fixes #2733#3321
Conversation
amrbashir
left a comment
There was a problem hiding this comment.
Thanks for taking the time to fix this.
You need to:
- rename
EmittedEventtoEventand remove any mention ofEmittedEvent - rename
EventtoRunEvent, obviously this will clash with theruntime::RunEventimport incore/tauri/src/app.rsso you're just gonna need to rename the import and not the original struct, something like thisuse runtime::RunEvent as RuntimeRunEvent
amrbashir
left a comment
There was a problem hiding this comment.
You also need to add a changefil in .changes folder and don't forget to mention the breaking change Event -> RunEvent
|
What would be the appropriate level for this change? Semver would dictate to use major since the API is changed, but semver doesn't seem to be enforced for |
|
It's not enforced because of the prelease stuff, so patch is fine, as this needs to land in v1 anyway (mainly because of the EventHandler fix) |
|
There seems to be a change request pending, but I can't figure out, what it is referring to. @amrbashir your name appears in the UI, have I overlooked something? |
|
@Chaostheorie Don't worry, that's just the UI not updating until he approves the PR. As far as i can see you got everything he requested so far 👍 |
|
@amrbashir and @FabianLars thank you for the great help and explanations. |
Expose
tauri::eventand renametauri::event::EventtoEmittedEvent. Temporary fix for #2733. This is supposed to be a POC for my internal use until #2733 is resolved in v1.x.What kind of change does this PR introduce?
Does this PR introduce a breaking change?