fix: Make CMD handle quotes " properly.#3334
Merged
lucasfernog merged 2 commits intotauri-apps:nextfrom Feb 6, 2022
philipborg:CMD-quotes
Merged
fix: Make CMD handle quotes " properly.#3334lucasfernog merged 2 commits intotauri-apps:nextfrom philipborg:CMD-quotes
" properly.#3334lucasfernog merged 2 commits intotauri-apps:nextfrom
philipborg:CMD-quotes
Conversation
FabianLars
requested changes
Feb 5, 2022
FabianLars
approved these changes
Feb 5, 2022
Member
FabianLars
left a comment
There was a problem hiding this comment.
The ",on Windows," is kinda in a weird place (maybe it'd be better at the end?). Anywayyy, good enough for me lol
Member
|
Urgh, forgot about that. We require all commits to be (gpg) signed. |
Contributor
Author
I will setup signing and rebase my commits then. May tweak the patchnote slightly then as well. |
Contributor
Author
|
@FabianLars I have now signed my commits. (I think, haven't worked a lot with signed commits before.) I also tweaked the patchnote slightly. |
philipborg
added a commit
to philipborg/CubeShuffle
that referenced
this pull request
Feb 5, 2022
Workaround for tauri-apps/tauri#3334
philipborg
added a commit
to philipborg/CubeShuffle
that referenced
this pull request
Feb 5, 2022
Workaround for tauri-apps/tauri#3334
amrbashir
requested changes
Feb 5, 2022
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
approved these changes
Feb 5, 2022
philipborg
added a commit
to philipborg/CubeShuffle
that referenced
this pull request
Feb 25, 2022
… be in now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Technically this is a breaking change, as any workarounds to this bug people have done may stop working. But this would just mean that they can remove those workarounds. But seeing as it hasn't been reported previously and only happens in complex commands I believe it's reasonably safe to make this bugfix. The presumably by far most common workaround, extracting the logic to a script, will likely work without issue.
Checklist
fix: remove a typo, closes #___, #___)Other information
Currently
beforeDevCommandandbeforeBuildCommandhave an issue where they can't deal with quotes properly on windows. Simple example is settingbeforeBuildCommandtoECHO %CD% && mkdir \"src-tauri\\websrc\"which will first echo out the expected project repository, then wrongly create the directoryC:\src-tauri\websrc.From
CMD /?We just wish to run the command provided in the configuration without extra parsing. Without
/Sthe user must escape certain characters for no benefit as we just wish to run whatever is entered in the configuration.Sidenote: It is not clear to me by reading the contributing guidelines if bugfixes requires issues to be created. If so I will create one.