-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make CMD handle quotes "
properly.
#3334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ",on Windows," is kinda in a weird place (maybe it'd be better at the end?). Anywayyy, good enough for me lol
Urgh, forgot about that. We require all commits to be (gpg) signed. |
I will setup signing and rebase my commits then. May tweak the patchnote slightly then as well. |
@FabianLars I have now signed my commits. (I think, haven't worked a lot with signed commits before.) I also tweaked the patchnote slightly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you :)
Workaround for tauri-apps/tauri#3334
Workaround for tauri-apps/tauri#3334
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
… be in now.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Technically this is a breaking change, as any workarounds to this bug people have done may stop working. But this would just mean that they can remove those workarounds. But seeing as it hasn't been reported previously and only happens in complex commands I believe it's reasonably safe to make this bugfix. The presumably by far most common workaround, extracting the logic to a script, will likely work without issue.
Checklist
fix: remove a typo, closes #___, #___
)Other information
Currently
beforeDevCommand
andbeforeBuildCommand
have an issue where they can't deal with quotes properly on windows. Simple example is settingbeforeBuildCommand
toECHO %CD% && mkdir \"src-tauri\\websrc\"
which will first echo out the expected project repository, then wrongly create the directoryC:\src-tauri\websrc
.From
CMD /?
We just wish to run the command provided in the configuration without extra parsing. Without
/S
the user must escape certain characters for no benefit as we just wish to run whatever is entered in the configuration.Sidenote: It is not clear to me by reading the contributing guidelines if bugfixes requires issues to be created. If so I will create one.