fix(core): window-specific event delivery, closes #3302#3344
Conversation
| } | ||
|
|
||
| fn validate_label(label: &str) { | ||
| pub fn is_label_valid(label: &str) -> bool { |
There was a problem hiding this comment.
nit: It should be is_valid_label() to match assert_valid_label()
|
Any help testing this would be very welcome. I did some tests using the API example and the multiwindow example and it looks correct, but there might be other use cases that I didn't cover. I'll merge this so it can get more visibility. |
|
I did some tests earlier and it seemed to work well in regard to the linked issue. Edit: So yes, more people doing their own testing is indeed a good idea 🙏 |
|
Thanks Fabian. Good thing we still have time to make tests and get feedback from the community (specially until the stable release) to get this working perfectly :P |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information